fix issue #371 #372
fix issue #371 #372
Conversation
| @@ -819,7 +819,7 @@ func (t *twirp) generateUtils() { | |||
|
|
|||
| t.P(`// doJSONRequest makes a JSON request to the remote Twirp service.`) | |||
| t.P(`func doJSONRequest(ctx `, t.pkgs["context"], `.Context, client HTTPClient, hooks *`, t.pkgs["twirp"], `.ClientHooks, url string, in, out `, t.pkgs["proto"], `.Message) (_ `, t.pkgs["context"], `.Context, err error) {`) | |||
| t.P(` marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: true}`) | |||
| t.P(` marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: !s.jsonCamelCase, EmitUnpopulated: !s.jsonSkipDefaults}`) | |||
There was a problem hiding this comment.
I don't think this would compile. The s receiver (server) is not accessible on this function. This function is used by the client to send requests, and the client constructor currently doesn't have options like the ones for the server WithServerJSONSkipDefaults and WithServerJSONCamelCaseNames.
To verify this, check the instructions on CONTRIBUTING.md on how to re-generate the code and run tests with the newly generated code.
There was a problem hiding this comment.
Thanks for the info. I will check on how to fix this issue properly and improve my pull request according to the instructions.
|
This PR is stale because it has been open for 60 days with no activity. Remove stale label / comment or this will be closed in 5 days |
Issue #371:
Description of changes:
generator.go in func doJSONRequest was changed from
to
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.