Generated Code for sending JSON requests is not in the sending path

[cloudsinmycoffee]

Hello there! We're using the twirp library at work for sending/receiving JSON requests via http. It has come to our attention that the omitempty flag is not supported when it comes to sending JSON requests. For now, our solution is to patch it manually after the code is being generated. The bug seems to be in protoc-gen-twirp/generator.go at func doJSONRequest and should be adapted in line 824 from

	t.P(`  marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: true}`)

to

	t.P(`  marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: !s.jsonCamelCase, EmitUnpopulated: !s.jsonSkipDefaults}`)

Thanks in advance!

[wmatveyenko]

Hi, we happily accept pull requests if you would like to fix it.

[cloudsinmycoffee]

Sure thing, I created a pull request :)

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label / comment or this will be closed in 5 days