Move selection manipulation into methods on Data #5

Sign in to view logs

Triggered via push November 5, 2023 06:21

twitchyliquid64

main

Status Failure

Total duration 2m 15s

Billable time 10m

Artifacts –

rust.yml

on: push

Annotations

11 errors and 51 warnings

Process completed with exit code 127.

Clippy: drawing/src/feature.rs#L124

this `else { if .. }` block can be collapsed

Clippy: drawing/src/feature.rs#L153

this `else { if .. }` block can be collapsed

Clippy: drawing/src/tools.rs#L80

match expression looks like `matches!` macro

Clippy: drawing/src/tools.rs#L136

using `clone` on type `Pos2` which implements the `Copy` trait

Clippy: drawing/src/tools.rs#L167

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

Clippy: drawing/src/lib.rs#L116

manual implementation of `Option::map`

Clippy: drawing/src/lib.rs#L143

use of `filter_map` with an identity function

Clippy: drawing/src/lib.rs#L169

using `clone` on type `DefaultKey` which implements the `Copy` trait

Clippy: drawing/src/lib.rs#L380

length comparison to zero

Clippy: drawing/src/lib.rs#L404

length comparison to zero

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check wasm32

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Check wasm32

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check wasm32

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check wasm32

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check wasm32

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check wasm32

profiles for the non root package will be ignored, specify profiles at the workspace root:

Check wasm32: detailer/src/lib.rs#L36

variable does not need to be mutable

Check wasm32: detailer/src/lib.rs#L82

unused variable: `p1`

Check wasm32: detailer/src/lib.rs#L82

unused variable: `p2`

Check wasm32: detailer/src/lib.rs#L142

unused variable: `ui`

Check wasm32

`detailer` (lib) generated 4 warnings (run `cargo fix --lib -p detailer` to apply 4 suggestions)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

profiles for the non root package will be ignored, specify profiles at the workspace root:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

profiles for the non root package will be ignored, specify profiles at the workspace root:

Check: detailer/src/lib.rs#L36

variable does not need to be mutable

Check: detailer/src/lib.rs#L82

unused variable: `p1`

Check: detailer/src/lib.rs#L82

unused variable: `p2`

Check: detailer/src/lib.rs#L142

unused variable: `ui`

`detailer` (lib) generated 4 warnings (run `cargo fix --lib -p detailer` to apply 4 suggestions)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

profiles for the non root package will be ignored, specify profiles at the workspace root:

Test Suite: detailer/src/lib.rs#L36

variable does not need to be mutable

Test Suite: detailer/src/lib.rs#L82

unused variable: `p1`

Test Suite: detailer/src/lib.rs#L82

unused variable: `p2`

Test Suite: detailer/src/lib.rs#L142

unused variable: `ui`

`detailer` (lib) generated 4 warnings (run `cargo fix --lib -p detailer` to apply 4 suggestions)

Test Suite: drawing/src/lib.rs#L564

unused import: `super::*`

`drawing` (lib test) generated 1 warning (run `cargo fix --lib -p drawing --tests` to apply 1 suggestion)