Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated byteorder dependency to ~1.4 in macros/Cargo.toml #46

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

riskable
Copy link
Contributor

This should fix issues with other crates (e.g. embedded-graphics master branch) that expect a newer version of the byteorder crate. I tested this change and it doesn't appear to impact anything (everything builds just fine 馃憤).

@haata
Copy link
Collaborator

haata commented Oct 14, 2022

I looked back in git history and the ~1.3 seems to go back to the initial commit.
I also ran some basic tests on 1.2.7 that also seemed to work (though nothing extensive).

I think upgrading to 1.4 should be fine.

@haata
Copy link
Collaborator

haata commented Oct 14, 2022

I also ran more tests while doing #47 as GitHub Actions weren't running clippy on this crate...

@haata haata merged commit 4a47f51 into twitchyliquid64:master Oct 14, 2022
@riskable
Copy link
Contributor Author

Thanks for merging this 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants