Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Commit

Permalink
Kill cruft no longer used/needed by comons.
Browse files Browse the repository at this point in the history
The 0.0.42 upgrade and switch to the standard pants bootsrap script
killed the need for both build-support/virtualenv and
build-support/python/libvirtualenv.sh.

I also noticed build-support/ivy/ci.ivysettings.xml was unused.

Testing Done:
CI went green here:
  https://travis-ci.org/twitter/commons/builds/75838991

Bugs closed: 409

Reviewed at https://rbcommons.com/s/twitter/r/2641/
  • Loading branch information
jsirois committed Aug 17, 2015
1 parent 88377b2 commit 146de30
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 81 deletions.
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ before_cache:
# operation).
- find $HOME/.ivy2/twitter-commons -type f -name "ivydata-*.properties" -print -delete
- rm -fv $HOME/.ivy2/twitter-commons/*.{css,properties,xml,xsl}
# The stats cache contains timestamped reports unused by CI but that
# thrash the cache. Skip caching these.
- rm -rf $HOME/.cache/pants/stats

cache:
directories:
- $HOME/.cache/pants
- $HOME/.ivy2/twitter-commons
- build-support/pants.venv
- build-support/virtualenv.dist

language: java

Expand Down
4 changes: 1 addition & 3 deletions build-support/bin/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ banner "CI BEGINS"
if [[ "${skip_bootstrap:-false}" == "false" ]]; then
banner "Bootstrapping pants"
(
./build-support/python/clean.sh && \
PANTS_VERBOSE=1 PEX_VERBOSE=1 PYTHON_VERBOSE=1 ./pants;
./pants goals
./pants help
) || die "Failed to bootstrap pants."
fi

Expand Down
21 changes: 0 additions & 21 deletions build-support/ivy/ci.ivysettings.xml

This file was deleted.

8 changes: 0 additions & 8 deletions build-support/python/clean.sh

This file was deleted.

20 changes: 0 additions & 20 deletions build-support/python/libvirtualenv.sh

This file was deleted.

27 changes: 0 additions & 27 deletions build-support/virtualenv

This file was deleted.

0 comments on commit 146de30

Please sign in to comment.