This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Fix collections.abc deprecation #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kwlzn
approved these changes
Jan 7, 2019
stuhood
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Jan 18, 2019
### Problem Use of `twitter.common.*==0.3.9` under Python 3 triggered deprecation warnings, which were fixed upstream in twitter-archive/commons#474 ### Solution Pull in `twitter.common.*==0.3.10` to remove the deprecation warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Python 3, the collections type classes (e.g.
MutableMapping,Iterable) were moved tocollections.abc. They were kept incollectionsfor backwards compatibility, but will be removed in Python 3.8 and cause a deprecation warning in Python 3.7.This leads to deprecation warnings for any Commons consumers, such as Pants.
Solution
Try to import
collections.abc, and fall back tocollections.This fallback will be necessary until Commons would ever decide to drop Python 2 support, if that ever would even happen.