fix up impl.

twitter-archive · Mar 2, 2011 · 46d415c · 46d415c
1 parent d035b09
commit 46d415c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/lib/template/src/main/scala/com/twitter/birdname/BirdNameServiceImpl.scala.erb b/lib/template/src/main/scala/com/twitter/birdname/BirdNameServiceImpl.scala.erb
@@ -2,14 +2,11 @@ package com.twitter.birdname
 
 import com.twitter.util._
 
-class BirdNameServiceImpl(config: BirdNameServiceConfig) extends BirdNameService {
+class BirdNameServiceImpl(port: Int) extends BirdNameService {
   val serverName = "BirdName"
-  val thriftPort = config.thriftPort
-
-  // TODO: Please implement
-
-  def hello() = {
-    Future("world")
-  }
+  val thriftPort = port
 
-}
+  def get_name() = {
+    Future("Jabberwocky")
+  }
+}
diff --git a/lib/template/src/main/scala/com/twitter/birdname/Main.scala.erb b/lib/template/src/main/scala/com/twitter/birdname/Main.scala.erb
@@ -5,8 +5,8 @@ import com.twitter.admin._
 object Main {
   def main(args: Array[String]) {
     val env = RuntimeEnvironment(this, args)
-    val impl = env.loadRuntimeConfig[BirdNameService]
-    impl.start
+    val service = env.loadRuntimeConfig[BirdNameService]
+    service.start()
   }
 }
 
diff --git a/lib/template/src/main/scala/com/twitter/birdname/config/BirdNameConfig.scala.erb b/lib/template/src/main/scala/com/twitter/birdname/config/BirdNameConfig.scala.erb
@@ -11,7 +11,7 @@ class BirdNameConfig extends ServerConfig[BirdNameService] {
   var serverPort: Int = 9999
 
   def apply(runtime: RuntimeEnvironment) = {
-    val server = new BirdNameService(serverPort)
+    val server = new BirdNameServiceImpl(serverPort)
     ServiceTracker.register(server)
     server
   }