Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Add classes to the tags surrounding entities #110

Closed
necolas opened this issue Jan 29, 2014 · 1 comment
Closed

Add classes to the tags surrounding entities #110

necolas opened this issue Jan 29, 2014 · 1 comment

Comments

@necolas
Copy link

necolas commented Jan 29, 2014

We should provide semantic classes for styling purposes: e.g., twitter-hashsymbol, twitter-atsymbol, twitter-emoji, twitter-text, etc.

We should drop / deprecate customizable tags because the correct tag is span.

Equivalent rb issue: twitter-archive/twitter-text-rb#110
@necolas necolas mentioned this issue Jan 29, 2014
Closed
necolas pushed a commit that referenced this issue Feb 5, 2014
Add support for adding classes to symbol/text tag
24236cc 
Fix #110
@necolas necolas mentioned this issue Feb 5, 2014
Closed
@necolas necolas changed the title Can't set a class on the symbol or text tags Add classes to the tags surrounding entities Jun 10, 2014
@necolas
Copy link
Author

necolas commented Jul 18, 2014

ping @jugyo

@necolas necolas closed this as completed Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for adding classes to symbol/text tag twitter-archive/twitter-text-js
1 participant
@necolas