Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Wrongly auto-linking email addresses as mentions. #123

Closed
SirRawlins opened this issue Nov 6, 2014 · 1 comment
Closed

Wrongly auto-linking email addresses as mentions. #123

SirRawlins opened this issue Nov 6, 2014 · 1 comment

Comments

@SirRawlins
Copy link

It seems that the auto_link method is wrongly detecting email addresses as mentions and linking them.

Twitter::Autolink.auto_link_usernames_or_lists 'My email is robert@weboffins.com'
 => "My email is robert@<a class=\"tweet-url username\" href=\"https://twitter.com/weboffins\" rel=\"nofollow\">weboffins</a>.com" 

This feels counter intuitive to me as it creates invalid links, and also present conflicts when used with the rinku gem for linking emails with mailto://

@jakl
Copy link
Contributor

jakl commented Dec 5, 2014

Thanks - now fixing in the new twitter-text mono-repo.
On rinku, their goals are a little different. Twitter-text makes linking behavior predictable/reproducable with twitter.com supporting slang/patterns in common languages on twitter.

@jakl jakl closed this as completed Dec 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants