Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails containing RT@ should not be usernames #2

Closed
jakl opened this issue Dec 5, 2014 · 2 comments
Closed

Emails containing RT@ should not be usernames #2

jakl opened this issue Dec 5, 2014 · 2 comments

Comments

@jakl
Copy link
Contributor

jakl commented Dec 5, 2014

I believe this was the only fix in the middle of active development during the switch to this mono-repo.
Would someone like to start a unified pull request here?
/cc @psychs @niw @jugyo

Previous work, not yet in the monorepo:
twitter-archive/twitter-text-conformance#83
twitter-archive/twitter-text-rb#123
twitter-archive/twitter-text-objc@18b3b2b
twitter-archive/twitter-text-objc@a3bdbaa
@psychs
Copy link
Contributor

psychs commented Dec 5, 2014

Can we have just separate commits for java/rb/js/objc?

@jakl
Copy link
Contributor Author

jakl commented Dec 5, 2014

Separate commits is good. Having these commits in the same pull request with conformance changes makes travis-ci most effective. A partially completed pull request can be completed by another person who might have more context in the remaining twitter-text implementations.

@twuttke twuttke mentioned this issue Jul 6, 2016
Merged
ronaldheft pushed a commit to thesocialstation/twitter-text that referenced this issue Dec 12, 2017
@kasperlewau
Merge pull request twitter#2 from FalconSocial/twitter-weight-js
fafe0f6 
Twitter weight js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@psychs @jakl @leeaustinadams