Skip to content

Commit

Permalink
Merge #51
Browse files Browse the repository at this point in the history
51: fix: fixed for the issue (#50) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/twitter-dart/twitter-oauth2-pkce/issues
[contributor guide]: https://github.com/twitter-dart/twitter-oauth2-pkce/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/twitter-dart/twitter-oauth2-pkce/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <kato.shinya.dev@gmail.com>
  • Loading branch information
bors[bot] and myConsciousness committed Nov 21, 2022
2 parents 120f583 + b625c9d commit ad78d12
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Note

## v1.0.1

- Fixed a bug where `TwitterOAuthException` did not implement `Exception`. ([#50](https://github.com/twitter-dart/twitter-oauth2-pkce/issues/50))

## v1.0.0

- Just release `v1.0.0`.
Expand Down
5 changes: 3 additions & 2 deletions lib/src/twitter_oauth_exception.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided the conditions.

class TwitterOAuthException {
TwitterOAuthException(this.message);
class TwitterOAuthException implements Exception {
/// Returns the new instance of [TwitterOAuthException].
const TwitterOAuthException(this.message);

/// The error message.
final String message;
Expand Down
9 changes: 4 additions & 5 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: twitter_oauth2_pkce
description: Provides the optimized and easiest way to integrate OAuth 2.0 PKCE with Twitter API in Flutter.
version: 1.0.0
version: 1.0.1
repository: https://github.com/twitter-dart/twitter-oauth2-pkce
issue_tracker: 'https://github.com/twitter-dart/twitter-oauth2-pkce/issues'
homepage: 'https://github.com/twitter-dart'
issue_tracker: "https://github.com/twitter-dart/twitter-oauth2-pkce/issues"
homepage: "https://github.com/twitter-dart"
environment:
sdk: '>=2.17.0 <3.0.0'
sdk: ">=2.17.0 <3.0.0"

dependencies:
flutter:
Expand All @@ -23,7 +23,6 @@ dev_dependencies:

# The following section is specific to Flutter.
flutter: null

# To add assets to your package, add an assets section, like this:
# assets:
# - images/a_dot_burr.jpeg
Expand Down

0 comments on commit ad78d12

Please sign in to comment.