Expose inputView and reloadInputViews method #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sheboo7191ii
approved these changes
Mar 25, 2021
niw
reviewed
Mar 26, 2021
| } | ||
| } | ||
|
|
||
| public override func reloadInputViews() { |
There was a problem hiding this comment.
Could you add /// :nodoc: for this line as well?
niw
approved these changes
Mar 27, 2021
niw
pushed a commit
that referenced
this pull request
Apr 10, 2021
**Problems** Due to the internal `UITextView` marked private. We can not access the `inputView` on it. **Solution** Make an interface to expose the API. So that the client could use the `inputView` to customize input. GitHub Pull Request: #15 #15 JIRA Issues: IOS-96982 Differential Revision: https://phabricator.twitter.biz/D642129
niw
added a commit
that referenced
this pull request
Apr 10, 2021
**Problems** `TextEditorView` provides some convinient `UIResponder` properties and method implementation, however it prevents changes default behavior and makes users difficult to use these. **Solution** - Provides `inputViewController` read-write property in addition to `inputView` which is implemented by #15. - Make `inputViewController`, `inputAccessoryView`, and `inputAccessoryViewController` goes up the responder chain as like `UITextView`, but not `inputView` (due to `UITextView` implementation.) - Reorganize `UIResponder` related implementation in the code. JIRA Issues: IOS-96169 Differential Revision: https://phabricator.twitter.biz/D649268
|
The change has been merged to the tip branch and pushed, closing the pull request. |
|
Thanks, @niw. I notice the PR is merged into the master. And is there any plan to make a release to make that feature debut? The Swift SPM needs a version tag to make the dependency update. |
|
@MainasuK We will release with a version tag when we confirmed it’s stable soon! |
|
I tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Due to the internal
UITextViewmarked private. We can not access theinputViewon it.Solution
Make an interface to expose the API. So that the client could use the
inputViewto customize input.Testing
Delear an empty
UIInputViewand call thereloadInputViews(). It works.