Change name of filter to filterBefore

twitter · Feb 17, 2015 · b9e5f7b · b9e5f7b
1 parent b5b0296
commit b9e5f7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/algebird-core/src/main/scala/com/twitter/algebird/Aggregator.scala b/algebird-core/src/main/scala/com/twitter/algebird/Aggregator.scala
@@ -333,7 +333,7 @@ trait MonoidAggregator[-A, B, +C] extends Aggregator[A, B, C] { self =>
   /**
    * Only aggregate items that match a predicate
    */
-  def filter[A1 <: A](pred: A1 => Boolean): MonoidAggregator[A1, B, C] =
+  def filterBefore[A1 <: A](pred: A1 => Boolean): MonoidAggregator[A1, B, C] =
     new MonoidAggregator[A1, B, C] {
       def prepare(a: A1) = if (pred(a)) self.prepare(a) else self.monoid.zero
       def monoid = self.monoid

diff --git a/algebird-test/src/test/scala/com/twitter/algebird/AggregatorLaws.scala b/algebird-test/src/test/scala/com/twitter/algebird/AggregatorLaws.scala
@@ -114,7 +114,7 @@ class AggregatorLaws extends PropSpec with PropertyChecks with Matchers {
   }
   property("MonoidAggregator.filter is correct") {
     forAll { (in: List[Int], ag: MonoidAggregator[Int, Int, Int], fn: Int => Boolean) =>
-      assert(ag.filter(fn).apply(in) == ag.apply(in.filter(fn)))
+      assert(ag.filterBefore(fn).apply(in) == ag.apply(in.filter(fn)))
     }
   }
 }