-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage via coveralls #376
Conversation
d28242f
to
dcbbc05
Compare
Changes Unknown when pulling dcbbc05 on add-coveralls into * on develop*. |
c9e9b84
to
f224b30
Compare
@johnynek any idea why this fails for me? "[info] - should measure 0.8 similarity in 1024 bytes with < 0.05 error *** FAILED *** |
Changes Unknown when pulling f224b30 on add-coveralls into * on develop*. |
@caniszczyk noisey test. These are probabilistic data structures. Sometimes you get unlucky. |
f224b30
to
abd0aca
Compare
Signed-off-by: Chris Aniszczyk <zx@twitter.com>
abd0aca
to
ca9f734
Compare
@caniszczyk thanks for getting this started. Trying again. Would love scalding and summingbird here too. |
So, this is green, but I don't see the coveralls badge. @caniszczyk thoughts? @travisbrown? |
Hi @johnynek, you'll need to add the badge to the README—something like this would work. I'm using shields.io SVG badges there, and I'm explicitly stating that the badges should reflect the status of the |
Add code coverage via coveralls
|
||
- scala: 2.11.5 | ||
script: ./sbt ++$TRAVIS_SCALA_VERSION clean coverage test | ||
after_success: "./sbt coveralls" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnynek since you aren't running coverageReport, what does this actually end up publishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mean coverageAggregate - https://github.com/scoverage/sbt-scoverage#multi-project-reports
Lets try this again.
https://coveralls.io/r/twitter/algebird
Signed-off-by: Chris Aniszczyk zx@twitter.com