Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage via coveralls #376

Merged
merged 4 commits into from
Feb 9, 2015
Merged

Add code coverage via coveralls #376

merged 4 commits into from
Feb 9, 2015

Conversation

caniszczyk
Copy link
Contributor

Lets try this again.

https://coveralls.io/r/twitter/algebird

Signed-off-by: Chris Aniszczyk zx@twitter.com

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling dcbbc05 on add-coveralls into * on develop*.

@caniszczyk caniszczyk force-pushed the add-coveralls branch 3 times, most recently from c9e9b84 to f224b30 Compare December 18, 2014 22:26
@caniszczyk
Copy link
Contributor Author

@johnynek any idea why this fails for me?

"[info] - should measure 0.8 similarity in 1024 bytes with < 0.05 error *** FAILED ***
[info] 0.0625 was not less than 0.05 (MinHasherTest.scala:35)"

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f224b30 on add-coveralls into * on develop*.

@johnynek
Copy link
Collaborator

@caniszczyk noisey test. These are probabilistic data structures. Sometimes you get unlucky.

Signed-off-by: Chris Aniszczyk <zx@twitter.com>
@johnynek
Copy link
Collaborator

johnynek commented Feb 6, 2015

@caniszczyk thanks for getting this started. Trying again. Would love scalding and summingbird here too.

@johnynek
Copy link
Collaborator

johnynek commented Feb 7, 2015

So, this is green, but I don't see the coveralls badge. @caniszczyk thoughts? @travisbrown?

@travisbrown
Copy link
Contributor

Hi @johnynek, you'll need to add the badge to the README—something like this would work.

I'm using shields.io SVG badges there, and I'm explicitly stating that the badges should reflect the status of the develop branch, since for example Travis's badge by default reflects the latest build on any branch, which isn't generally what you want.

johnynek added a commit that referenced this pull request Feb 9, 2015
Add code coverage via coveralls
@johnynek johnynek merged commit 3963a65 into develop Feb 9, 2015
@johnynek johnynek deleted the add-coveralls branch February 9, 2015 20:43

- scala: 2.11.5
script: ./sbt ++$TRAVIS_SCALA_VERSION clean coverage test
after_success: "./sbt coveralls"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnynek since you aren't running coverageReport, what does this actually end up publishing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants