Add SummingWithHitsCache class to also track key hits. #410
Conversation
| extends SummingCache[K, V](capacity)(sgv) { | ||
|
|
||
| def putWithHits(m: Map[K, V]): (Int, Option[Map[K, V]]) = { | ||
| val keyHits = m.keys.filter(cache.get(_).isDefined).size |
There was a problem hiding this comment.
m.keys.count(cache.contains)
|
Let's add some tests, but otherwise this looks good. What do you think about the private constructor? That was unusual before and caused a problem here. Should we just make the constructor public? What do we gain from private constructor? (I did it before, but I think it was a mistake now). |
|
I actually don't know the reason of why it's private in the first place. So I just changed it to protected to make this work. If you feel the private accessor is not needed any more, I think let's go ahead change it to public. |
|
@johnynek Added several tests for it. |
| /** | ||
| * A SummingCache that also tracks the number of key hits | ||
| */ | ||
| class SummingWithHitsCache[K, V] private (capacity: Int)(implicit sgv: Semigroup[V]) |
There was a problem hiding this comment.
let's make this one public too
There was a problem hiding this comment.
Updated.
Just out of curiosity, what's the original reason to make the constructor private?
|
after we fix the public issue, LGTM. |
Add SummingWithHitsCache class to also track key hits.
No description provided.