Adding scoped top-N CMS monoid #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you merge with develop to get the sbt fix? |
|
Sorry my bad, git foo on cmd line broke stuff and closed all of these |
| @@ -780,7 +821,7 @@ case class TopNLogic[K](heavyHittersN: Int) extends HeavyHittersLogic[K] { | |||
|
|
|||
| require(heavyHittersN > 0, "heavyHittersN must be > 0") | |||
|
|
|||
| override def purgeHeavyHitters(cms: CMS[K])(hitters: HeavyHitters[K]): HeavyHitters[K] = { | |||
| def purgeHeavyHitters(cms: CMS[K])(hitters: HeavyHitters[K]): HeavyHitters[K] = { | |||
There was a problem hiding this comment.
why did you remove the override here?
There was a problem hiding this comment.
Eh I kinda love-hate the override keyword. It doesn't require that the base class/trait actually implements the method (i.e., so that we know if super is interesting). Then again, plain def doesn't require that the base class/trait declares the method either. I'll put it back.
|
just a few minor comments, then let's merge. |
johnynek
added a commit
that referenced
this pull request
Aug 5, 2015
Adding scoped top-N CMS monoid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #468
A bit of refactoring out duplicate code. Leaving in
TopPctCMSAggregatorandTopNCMSAggregatorso this should be binary compatible.