remove unused imports, fix bug #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
May 15, 2018
| @@ -107,7 +101,7 @@ class ApproxHHTracker(hhPct: HeavyHittersPercent, updateFreq: UpdateFrequency, r | |||
|
|
|||
| if (hh.containsKey(item)) { | |||
| val v = hh.get(item) | |||
| val newItemCount = +1L | |||
| val newItemCount = v + 1L | |||
There was a problem hiding this comment.
@ianoc can you double check this? This triggered a warning in scalac (which we ignored), but it looks like we intended to increment the count, but lost the v. What do you think?
I guess this means this cache was always pruning...
There was a problem hiding this comment.
ouch, yeah this change looks right/looks like a bug.
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## develop #660 +/- ##
===========================================
- Coverage 89.44% 89.44% -0.01%
===========================================
Files 113 113
Lines 8945 8959 +14
Branches 490 490
===========================================
+ Hits 8001 8013 +12
- Misses 944 946 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ianoc can you review?