Saturated bloomfilter size

[cesarcolle]

I reproduce the error from issue #632

1. The error from the initial issue is reproduced with the test :

    "return his size event if it's saturated" in {
      val bfMonoid = BloomFilterMonoid[String](5, 13)
      val strings = Array(1, 2, 3, 4, 5, 6, 7, 8, 9, 10).map(_.toString)
      val bf = bfMonoid.create(strings: _*)

      assert(bf.size.min > 0)
    }

throws :

[info] - should return his size event if it's saturated *** FAILED ***
[info]   java.lang.IllegalArgumentException: requirement failed

Due to, I think , #632 (comment) we discuss before.

2. This is not the only error I found, seem like a saturated bloomfilter also provided a huge max approximation for a given input. But not throw an exception

Coming from the comment (L.135 to 138 ) in Bloomfilter file :

/*
   * approximationWidth defines an interval around the maximum-likelihood cardinality
   * estimate. Namely, the approximation returned is of the form
   * (min, estimate, max) =
   *   ((1 - approxWidth) * estimate, estimate, (1 + approxWidth) * estimate)
   */

But there is a problem between the result from the :

    "return a max approximate size if it's saturated" in {
      val bfMonoid = BloomFilterMonoid[String](5, 13)
      val strings = List(8, 9, 8, 10, 1, 8, 11, 7, 7, 1).map(_.toString)
      val bf = bfMonoid.create(strings: _*)
      // even it's seems big. This assert fail..
      assert(bf.size.max < strings.length * 100)
    }

which return :

[info] - should return a max approximate size if it's saturated *** FAILED ***
[info]   2147483647 was not less than 1000 (BloomFilterTest.scala:459)

2147483647 is a particular number because it's the maximum 32 bits integer you can have.

[johnynek]

Thanks, this looks good.

Could we possibly revert the style changes for code you are not touching?

[cesarcolle]

Sorry it's Intelij clean code not working with the .scalafmt.conf of the project. I apply algebird's scalafmt by hand

[codecov-io]

Codecov Report

Merging #666 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #666      +/-   ##
===========================================
+ Coverage    89.31%   89.52%   +0.21%     
===========================================
  Files          113      113              
  Lines         8944     8945       +1     
  Branches       490      494       +4     
===========================================
+ Hits          7988     8008      +20     
+ Misses         956      937      -19

Impacted Files	Coverage Δ
.../main/scala/com/twitter/algebird/BloomFilter.scala	95.15% <100%> (+0.9%)	⬆️
...c/main/scala/com/twitter/algebird/MapAlgebra.scala	75.67% <0%> (+0.9%)	⬆️
.../main/scala/com/twitter/algebird/Applicative.scala	61.76% <0%> (+2.94%)	⬆️
.../main/scala/com/twitter/algebird/Successible.scala	91.66% <0%> (+4.16%)	⬆️
...src/main/scala/com/twitter/algebird/Interval.scala	81.73% <0%> (+5.21%)	⬆️
...ala/com/twitter/algebird/ApproximateProperty.scala	82% <0%> (+10%)	⬆️
...scala/com/twitter/algebird/PredecessibleLaws.scala	86.66% <0%> (+20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdb079...ee3b2db. Read the comment docs.

[CLAassistant]

All committers have signed the CLA.