Optionally write resolution manifests #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolution manifests include information about all the transitive dependencies that are included as part of the resolution for every third party target. The resolution manifests are written if and only if `--manifests-root` is passed to multiversion. This path is used as the root under which the manifests should be written. One manifest is written per resolved target. Given a manifest root set to `foo/bar`, and a target `fizz/buzz:quux`, the manifest will be written in `foo/bar/fizz/buzz/bazel-deps-quux.txt`.
Duhemm
commented
May 7, 2021
| } yield index.reconciledDependency(dependency).repr | ||
| val output = dependencies.distinct.sorted.mkString(System.lineSeparator()) | ||
| Files.createDirectories(manifest.getParent()) | ||
| Files.write(manifest, output.getBytes) |
There was a problem hiding this comment.
This probably needs a header showing this is a generated file.
There was a problem hiding this comment.
In phabricator the @generated header collapses the file by default in the phab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution manifests include information about all the transitive
dependencies that are included as part of the resolution for every third
party target.
The resolution manifests are written if and only if
--manifests-rootis passed to multiversion. This path is used as the root under which the
manifests should be written. One manifest is written per resolved
target.
Given a manifest root set to
foo/bar, and a targetfizz/buzz:quux,the manifest will be written in
foo/bar/fizz/buzz/bazel-deps-quux.txt.