Add option to print yaml logs to Stdout #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Update the writeLintReport function to print to stdout if given a '-' as a file path > Update the completeEither function to take an optional 'silence' parameter to silence human readable logs when printing the yaml to stdout
|
|
eed3si9n
reviewed
May 12, 2021
multiversion/src/main/scala/multiversion/commands/LintCommand.scala
Outdated
Show resolved
Hide resolved
eed3si9n
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiversion linting error logs need to be parsed and are currently printed to stdout in a human readable format
Solution
Update the writeLintReport function to print YAML to stdout if given a '-' as a file path
Update the completeEither function to take an optional 'silence' parameter to silence human readable logs when printing the YAML to stdout