Moves to 2.10.x as the default and to scalatest #176
Conversation
…test_2.10 Conflicts: project/Build.scala
| @@ -58,7 +58,7 @@ object GenericAvroCodecsSpecification extends Specification with BaseProperties | |||
| val testRecord = buildGenericAvroRecord(("2012-01-01", 1, 12)) | |||
| val bytes = Injection[GenericRecord, Array[Byte]](testRecord) | |||
| val attempt = Injection.invert[GenericRecord, Array[Byte]](bytes) | |||
| attempt.get must_== testRecord | |||
| attempt.get shouldEqual testRecord | |||
There was a problem hiding this comment.
you should check out the assert macro and diagrammatic asserts, it's incredibly cool.
There was a problem hiding this comment.
FYI for anyone else who sees this: http://www.artima.com/docs-scalatest-2.2.0-RC1/index.html#org.scalatest.DiagrammedAssertions
Those look very slick. I'll swap all these shouldEqual over to asserts to get the base info. Looks like we can flick those on in future for more info
…an use the assert macro's from scalatest and also get better combined test output info.
|
This turned into a little more monsterish than I originally intended in size. But all warnings are gone from the code under 2.10, all manifests are gone. Also all test entry points are now scalatest, using its wrappers to do scalacheck tests. Gives a more common platform for tests imo. Thought's @johnynek ? There are a bunch of pro's and cons with certain parts getting longer or shorter between the two. But one nice thing is getting scalatests macro's, we have some horrible hacks of do a list that makes bools and then do a forall at the end of x => x. With the asserts instead we will get more info at the call site. I also nuked the old JavaTests.scala, I confirmed under scalatest the Javatests are being run anyway. |
| @@ -41,6 +41,7 @@ trait Bufferable[T] extends Serializable { | |||
| get(from) match { | |||
| case Success(tup @ _) => tup | |||
| case Failure(InversionFailure(_, t)) => throw t | |||
| case Failure(t) => throw t | |||
There was a problem hiding this comment.
nice catch (or, nice throw!)
There was a problem hiding this comment.
the warnings housekeeping tossed it up, also just a an interesting one: json4s needs a manifest, though in our code we can supply the call site with a TypeTag and ClassTag and scala has an implicit conversion to a manifest for it.
|
shipit |
Moves to 2.10.x as the default and to scalatest
| def toJson[T <: SpecificRecordBase: Manifest](schema: Schema): Injection[T, String] = { | ||
| val klass = manifest[T].erasure.asInstanceOf[Class[T]] | ||
| def toJson[T <: SpecificRecordBase: ClassTag](schema: Schema): Injection[T, String] = { | ||
| val klass = classTag[T].runtimeClass.asInstanceOf[Class[T]] |
There was a problem hiding this comment.
do we want to just have a method in the package which is the following:
def klass[T](implicit ct: ClassTag[T]): Class[T] = ct.runtimeClass.asInstanceOf[Class[T]]
Not a big deal at all but could get rid of the boilerplate at least.
No description provided.