Add macros to create Trys #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * that would still require calling apply on that function. | ||
| * In contrast, here, we can inline it directly. | ||
| */ | ||
| def fastAttempt[A, B](b: B)(inv: A): Try[A] = macro MacroImpl.fastAttempt[A, B] |
There was a problem hiding this comment.
Does the inv type signature of A work here? since we can inline it at the callsite we can just take a FN B => A and do it in place? nifty
There was a problem hiding this comment.
inv is basically a lazy parameter that is inlined (same idea as fastTry).
val maybeNum = "12"
fastAttempt(maybeNum)(maybeNum.toInt)I assume that if we put just the function, it will inline the function object and then call the apply on it. To do otherwise, I assume will take a Tree that we need to walk.
johnynek
force-pushed
the
fastTryMacro
branch
from
ef9e076
to
2b34351
Compare
|
LGTM, merge when green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just toy macros, but the fastAttempt in particular could make Injections a bit faster that are defined using it (rather than Inversion.attempt).