Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

En-threadsafe json injections for collections #224

Merged
merged 1 commit into from
Jul 20, 2015
Merged

En-threadsafe json injections for collections #224

merged 1 commit into from
Jul 20, 2015

Commits on Jul 9, 2015

  1. Replace frightening fromBuilder method with new fromCollection 

    The existing fromBuilder method reused the same builder for multiple `invert`
calls, which is not safe under multithreading: one thread might, for example,
clear the builder while another thread is adding elements.

This patch changes the implementation to get a new builder every time from the
CanBuildFrom, and puts that behind the existing fromCollection interface. The
existing injections for specific collections should not change behaviour.
    @bkirwi-stripe
    bkirwi-stripe committed Jul 9, 2015
    Configuration menu
    Copy the full SHA
    3f1cfb7 View commit details
    Browse the repository at this point in the history