Make string Injections safer. Fix #199 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,9 +33,22 @@ trait StringInjections extends NumericInjections { | |||
|
|
|||
| def withEncoding(encoding: String): Injection[String, Array[Byte]] = | |||
| new AbstractInjection[String, Array[Byte]] { | |||
| private[this] val decRef = { | |||
| val cs = Charset.forName(encoding) | |||
| new AtomicSharedState(() => cs.newDecoder.onUnmappableCharacter(CodingErrorAction.REPORT)) | |||
There was a problem hiding this comment.
is the charset threadsafe itself?
Maybe we should have more like a () => {
val cs = Char...
})
? if threadsafe though doesn't seem like any reason to ofc
|
I've no problem with atomics :) |
|
LGTM |
ianoc
added a commit
that referenced
this pull request
Jan 25, 2016
Make string Injections safer. Fix #199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #199
?r @ianoc
Will you humor me on the atomics? :)