-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes vertical-three-colors in Firefox #4274
Conversation
Well, did you test it :)? |
Of course i tried it with |
Force percentage value on .vertical-three-colors() gradient mixin.
How did you call the mixin? |
This patch makes the mixin break in Firefox if it's called with px like |
Maybe you should change the default value @colorStop: 50% to @colorStop: .50 to clearify the usage of the mixin. From my personal perspective I would prefer to use the mixin in this way: |
Let's just throw in the colorStop value directly and not asume or dictate the use of a procentual value. Using px is allowed and makes sense to e.g. fake shadows or align with logo images. |
As others have stated, this patch breaks mixin when percentage or pixel value is passed. Should be reverted I think. |
Force percentage value on .vertical-three-colors() gradient mixin.
Force percentage value on .vertical-three-colors() gradient mixin.
The less mixin for vertical-three-colors doesn't seem to work in Firefox 13.0.1.
It just displays the default background-image option. It looks like Firefox want a percentage value.
I hope
*100%
works fine.Old Request was #4055