Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes vertical-three-colors in Firefox #4274

Merged
merged 1 commit into from
Aug 15, 2012

Conversation

Marmelatze
Copy link
Contributor

The less mixin for vertical-three-colors doesn't seem to work in Firefox 13.0.1.
It just displays the default background-image option. It looks like Firefox want a percentage value.

I hope *100% works fine.

Old Request was #4055

@travisbot
Copy link

This pull request passes (merged fa38ab5 into 88deb08).

@mdo
Copy link
Member

mdo commented Aug 3, 2012

I hope *100% works fine.

Well, did you test it :)?

@Marmelatze
Copy link
Contributor Author

Of course i tried it with #gradient > .vertical-three-colors(#cc0303, #920000, .26, #410000);.
It works well in Chrome, but fails in Firefox and just displays the simple background.

mdo added a commit that referenced this pull request Aug 15, 2012
Force percentage value on .vertical-three-colors() gradient mixin.
@mdo mdo merged commit b0437be into twbs:2.1.0-wip Aug 15, 2012
@Marmelatze
Copy link
Contributor Author

How did you call the mixin?

@jcdirks
Copy link

jcdirks commented Aug 22, 2012

This patch makes the mixin break in Firefox if it's called with px like
#gradient > .vertical-three-colors(#ffffff, #eeeeee, 50px, #eeeeee);
I'd rather suggest to use 26% instead of .26 for procentual values and revert this patch.

@skoepp
Copy link

skoepp commented Aug 27, 2012

Maybe you should change the default value @colorStop: 50% to @colorStop: .50 to clearify the usage of the mixin.

From my personal perspective I would prefer to use the mixin in this way:
#gradient > .vertical-three-colors(#DBDBDB, #F9F9F9, 75%, #DDDDDD);

@jcdirks
Copy link

jcdirks commented Aug 27, 2012

Let's just throw in the colorStop value directly and not asume or dictate the use of a procentual value. Using px is allowed and makes sense to e.g. fake shadows or align with logo images.

@thomaspark
Copy link

As others have stated, this patch breaks mixin when percentage or pixel value is passed. Should be reverted I think.

stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
Force percentage value on .vertical-three-colors() gradient mixin.
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Force percentage value on .vertical-three-colors() gradient mixin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants