support proxy. #26
support proxy. #26
Conversation
| @@ -180,6 +180,12 @@ Package.prototype.download = function () { | |||
| var src = url.parse(this.assetUrl); | |||
| var req = src.protocol === 'https:' ? https : http; | |||
|
|
|||
| if (process.env.HTTP_PROXY) { | |||
| var proxy = url.parse(process.env.HTTP_PROXY); | |||
There was a problem hiding this comment.
can you just set src here? also, doesn't look like you're using proxy.path anywhere…
src = url.parse(process.env.HTTP_PROXY);
|
not really sure what you're trying to do with this (sorry if im being dense)… bower should already support http urls. just use this format |
I think so. |
|
what i meant by my comment is, i don't think we need this patch… thanks! |
Even if bower support http scheme for git, we can't access over the remote. I think bower need this patch. Thanks. |
|
At the moment, I cannot use bower in corporate environment because of the lack of proxy support... |
|
can you provide a test case for what this feature is adding? |
|
not impossible, but the tests need to write proxy server. |
|
feels kinda sketch… have you tested this with a proxy, and confirmed it works? |
Yep. But I have not tested with a proxy required authentication. :-( |
|
So is there any decision yet? I really would appreciate proxy support because we cannot use Bower in our company so far. |
|
yep, published as 0.2.0 |
|
Thanks. |
|
I think this is still an issue for when the URL is |
|
@hale What do you mean? This change replace |
|
Ah okay, sorry I must have misunderstood the code. Bower doesn't work for me behind a proxy when other command line utils do, but perhaps this is specific to my network. |
|
Are you using proxy require authentication? |
|
Nope. |
|
Do you have |
|
I just tried setting the proxy in a different way and it works. Thanks, appreciate the help :) |
|
What dose this "a different way" means ? How to do? |
|
@hale, how/where did you configure it to make it work? |
Validate that `main` conforms to the bower.json spec
if having HTTP_PROXY environment variable, you'll be possible to get working with http proxy.