Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating akka dependency to 2.3.2 #182

Merged
merged 2 commits into from May 11, 2014
Merged

updating akka dependency to 2.3.2 #182

merged 2 commits into from May 11, 2014

Conversation

lamdor
Copy link
Contributor

@lamdor lamdor commented Apr 30, 2014

I'm not fully sure if akka 2.2 and akka 2.3 are fully binary compatible nor if chill-akka would have any problems with it. But we are on our way to upgrading to akka 2.3 and as this is one of our major dependencies (thanks), I wanted to make sure that it was okay too. And it was. So here you go.

@johnynek
Copy link
Collaborator

johnynek commented May 7, 2014

Thanks for taking the time to do this.

So, we tend to keep the lowest dependency that is compatible with the most recent version. In this case, I think you are okay using this and letting sbt evict our dep in favor of yours. So I would tend to think we should not merge as is.

What I would merge is that akka should be a % provided dependency, since clearly you need to have your code depend on akka to use chill-akka. Would you be willing to make that minor change for us?

@lamdor
Copy link
Contributor Author

lamdor commented May 9, 2014

Agreed. I've made the change. Thanks.

@johnynek
Copy link
Collaborator

Great! Thanks.

johnynek added a commit that referenced this pull request May 11, 2014
updating akka dependency to 2.3.2
@johnynek johnynek merged commit 53c7096 into twitter:develop May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants