Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QTreeSerializer #305

Merged
merged 1 commit into from
Mar 31, 2018
Merged

add QTreeSerializer #305

merged 1 commit into from
Mar 31, 2018

Conversation

nevillelyh
Copy link
Collaborator

@nevillelyh nevillelyh commented Mar 30, 2018

Default kryo serialization for QTree is not deterministic due to other fields in the class, and this causes problem in some frameworks like Apache Beam which detects mutation of input element via serialization.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #305 into develop will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
+ Coverage    52.13%   52.59%   +0.46%     
===========================================
  Files           42       42              
  Lines         1314     1327      +13     
  Branches        38       38              
===========================================
+ Hits           685      698      +13     
  Misses         629      629
Impacted Files Coverage Δ
...com/twitter/chill/algebird/AlgebirdRegistrar.scala 100% <100%> (ø) ⬆️
...m/twitter/chill/algebird/AlgebirdSerializers.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2fc96...4622f7e. Read the comment docs.

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnynek johnynek merged commit d0ea8a9 into twitter:develop Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants