Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Convert 3rdparty/python to use the python_requirements target. #431

Closed
wants to merge 2 commits into from

Conversation

mateor
Copy link
Contributor

@mateor mateor commented May 12, 2016

Twitter commons was using a wrapper function around its python
dependencies to create python_requirement_library targets.
The python_requirements library is able to understand a pip
requirements.txt file and convert each entry into the
python_requirement_library target needed by Pants.

The python_requirements target uses the project name as a target
name. The original wrapper was maintained for a few dependencies
when their name clashed with Pants BUILD file conventions.

I also removed the easy_install thrift, it looks like it was
put in place to service aurora, who was later unblocked.

Let me know if you think it should be returned:
pantsbuild/pants#2533

The purpose of this change is to enable a simple interface to convert
some python dependencies from being hardcoded to a single rev into
being able to be satisfied by a release range. I will submit
any dependency version changes separately.

Twitter commons was using a wrapper function around its python
dependencies to create python_requirement_library targets.
The python_requirements library is able to understand a pip
requirements.txt file and convert each entry into the
python_requirement_library target needed by Pants.

The python_requirements target uses the project name as a target
name. The original  wrapper was maintained for a few dependencies
when their name clashed with Pants BUILD file conventions.

I also removed the easy_install thrift, it looks like it was
put in place to service aurora, who was later unblocked.

Let me know if you think it should be returned:
pantsbuild/pants#2533

The purpose of this change is to enable a simple interface to convert
some python dependencies from being hardcoded to a single rev into
being able to be satisfied by a release range. I will submit
any dependency version changes separately.
It turns out that the bug wasn't unblocked but merely worked
around. Thrift 0.0.93 is not viable for python.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grimreaper
Copy link

Thank you for your contribution. Unfortunately, we’re not going to continue maintaining twitter-commons and are archiving all pull requests.

@grimreaper grimreaper closed this Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants