Add tests to ensure all rules are added to their rulesets

gradle/libs.versions.toml

@@ -20,6 +20,7 @@ gradleMavenPublishPlugin = "com.vanniktech:gradle-maven-publish-plugin:0.22.0"
 junit5 = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit" }
 junit5-params = { module = "org.junit.jupiter:junit-jupiter-params", version.ref = "junit" }
 assertj = "org.assertj:assertj-core:3.23.1"
+reflections = "org.reflections:reflections:0.10.2"
 
 [plugins]
 spotless = { id = "com.diffplug.spotless", version = "6.11.0" }

rules/detekt/build.gradle

@@ -29,4 +29,5 @@ dependencies {
     testImplementation libs.junit5
     testImplementation libs.junit5.params
     testImplementation libs.assertj
+    testImplementation libs.reflections
 }

rules/detekt/src/test/kotlin/com/twitter/compose/rules/detekt/TwitterComposeRuleSetProviderTest.kt

@@ -0,0 +1,23 @@
+// Copyright 2022 Twitter, Inc.
+// SPDX-License-Identifier: Apache-2.0
+package com.twitter.compose.rules.detekt
+
+import com.twitter.rules.core.detekt.TwitterDetektRule
+import io.gitlab.arturbosch.detekt.api.Config
+import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
+import org.junit.jupiter.api.Test
+import org.reflections.Reflections
+
+class TwitterComposeRuleSetProviderTest {
+
+    private val ruleSetProvider = TwitterComposeRuleSetProvider()
+    private val ruleSet = ruleSetProvider.instance(Config.empty)
+
+    @Test
+    fun `ensure all rules in the package are represented in the ruleset`() {
+        val reflections = Reflections(ruleSetProvider.javaClass.packageName)
+        val ruleClassesInPackage = reflections.getSubTypesOf(TwitterDetektRule::class.java)
+        val ruleClassesInRuleSet = ruleSet.rules.filterIsInstance<TwitterDetektRule>().map { it::class.java }.toSet()
+        assertThat(ruleClassesInRuleSet).containsExactlyInAnyOrderElementsOf(ruleClassesInPackage)
+    }
+}

rules/ktlint/build.gradle

@@ -29,4 +29,5 @@ dependencies {
     testImplementation libs.junit5
     testImplementation libs.junit5.params
     testImplementation libs.assertj
+    testImplementation libs.reflections
 }

rules/ktlint/src/test/kotlin/com/twitter/compose/rules/ktlint/TwitterComposeRuleSetProviderTest.kt

@@ -2,9 +2,32 @@
 // SPDX-License-Identifier: Apache-2.0
 package com.twitter.compose.rules.ktlint
 
-import com.pinterest.ktlint.test.RuleSetProviderTest
+import com.twitter.rules.core.ktlint.TwitterKtlintRule
+import org.assertj.core.api.AssertionsForInterfaceTypes.assertThat
+import org.junit.jupiter.api.Test
+import org.reflections.Reflections
 
-class TwitterComposeRuleSetProviderTest : RuleSetProviderTest(
-    rulesetClass = TwitterComposeRuleSetProvider::class.java,
-    packageName = "com.twitter.rules.ktlint.compose"
-)
+class TwitterComposeRuleSetProviderTest {
+
+    private val ruleSetProvider = TwitterComposeRuleSetProvider()
+    private val ruleClassesInPackage = Reflections(ruleSetProvider.javaClass.packageName)
+        .getSubTypesOf(TwitterKtlintRule::class.java)
+
+    @Test
+    fun `ensure all rules in the package are represented in the old ruleset`() {
+        @Suppress("DEPRECATION")
+        val ruleSet = ruleSetProvider.get()
+        val ruleClassesInRuleSet = ruleSet.rules.filterIsInstance<TwitterKtlintRule>().map { it::class.java }.toSet()
+        assertThat(ruleClassesInRuleSet).containsExactlyInAnyOrderElementsOf(ruleClassesInPackage)
+    }
+
+    @Test
+    fun `ensure all rules in the package are represented in the new ruleset`() {
+        val ruleSet = ruleSetProvider.getRuleProviders()
+        val ruleClassesInRuleSet = ruleSet.map { it.createNewRuleInstance() }
+            .filterIsInstance<TwitterKtlintRule>()
+            .map { it::class.java }
+            .toSet()
+        assertThat(ruleClassesInRuleSet).containsExactlyInAnyOrderElementsOf(ruleClassesInPackage)
+    }
+}