finagle-core: Use configured deadline params #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem We can set the `TimeoutFilter.PropagateDeadlines` and `TimeoutFilter.PreferDeadlineOverTimeout` to configure behavior on the Client. When the MethodBuilder interface is used, the `perRequestModule` does only look at the `Default` values of these configurations, preventing custom configuration. Solution Pass the `TimeoutFilter.PropagateDeadlines` and `TimeoutFilter.PreferDeadlineOverTimeout` as Params to the `perRequestModule` to instantiate the `TimeoutFilter` with correct configuration. Result The MethodBuilder will pick up configured `TimeoutFilter.PropagateDeadlines` and `TimeoutFilter.PreferDeadlineOverTimeout` parameters. Signed-off-by: Jens Kat <jenskat@gmail.com>
DieBauer
force-pushed
the
methodbuilder-config
branch
from
ab11ad4
to
9c22777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We can set the
TimeoutFilter.PropagateDeadlinesandTimeoutFilter.PreferDeadlineOverTimeoutto configure behavior on the Client. When the MethodBuilder interface is used, theperRequestModuledoes only look at theDefaultvalues of these configurations, preventing custom configuration.Solution
Pass the
TimeoutFilter.PropagateDeadlinesandTimeoutFilter.PreferDeadlineOverTimeoutas Params to theperRequestModuleto instantiate theTimeoutFilterwith correct configuration.Result
The MethodBuilder will pick up configured
TimeoutFilter.PropagateDeadlinesandTimeoutFilter.PreferDeadlineOverTimeoutparameters.Signed-off-by: Jens Kat jenskat@gmail.com