Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a flavor of the IntegrationTestMixin that doesn't use Mockito #434

Closed
cacoco opened this issue Sep 7, 2017 · 1 comment
Closed
Labels

Comments

@cacoco
Copy link
Contributor

cacoco commented Sep 7, 2017

It would be great to have a version of the IntegrationTestMixin that does not rely on Mockito allowing users to "bring their own mocking" to the table. This would help in the cases where people would like to use a newer version of Mockito that the framework currently supports or some other mocking framework altogether.

This would most likely entail moving the mocking functionality to another trait and figuring out the best way to delay mixing it in until where necessary to maintain backward compatibility.

Along those lines, we generally ask that users mix in the com.twitter.inject.Mockito trait when mocking so we may have an avenue in which we can shift around responsibility and maintain backward compatibility by moving the mocking functionality currently in the IntegrationTestMixin into the com.twitter.inject.Mockito trait itself.

Then users can choose to use the IntegrationTestMixin and its subclasses (which would be decoupled from any mocking) with or without the Mockito trait.

@cacoco
Copy link
Contributor Author

cacoco commented Jan 15, 2019

After 841f697 the IntegrationTestMixin no longer has any mocking dependency and users should be able to "bring their own" mocking to their tests.

@cacoco cacoco closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant