This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 375
RateTracker Improvements #53
Comments
Sounds like a nice improvement to add |
@toffaletti feel free to issue a pull request when you're ready |
Apologies, I was under the impression that mentioning the issue id in the commit message would turn this into a pull request. |
kevinoliver
added a commit
that referenced
this issue
Apr 22, 2013
This is fixed now in a3e552c |
Clearly Define the issue in RateTracker. Which type of parameters based on this RateTracker tracking the result... Then we have solve the problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'd like to replace my firehose client with hbc, but I've hit a wall porting some existing functionality. Essentially my counter-part to RateTracker does persistence to ZooKeeper so backfill count can be calculated over process restarts.
My plan is to make RateTracker an interface, move the current functionality into an implementation BasicRateTracker, and allow RateTracker to be set with ClientBuilder. Does this seem feasible and something you'd like to merge?
The text was updated successfully, but these errors were encountered: