Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

RateTracker Improvements #53

Closed
toffaletti opened this issue Apr 19, 2013 · 5 comments
Closed

RateTracker Improvements #53

toffaletti opened this issue Apr 19, 2013 · 5 comments

Comments

@toffaletti
Copy link
Contributor

I'd like to replace my firehose client with hbc, but I've hit a wall porting some existing functionality. Essentially my counter-part to RateTracker does persistence to ZooKeeper so backfill count can be calculated over process restarts.

My plan is to make RateTracker an interface, move the current functionality into an implementation BasicRateTracker, and allow RateTracker to be set with ClientBuilder. Does this seem feasible and something you'd like to merge?

@kevinoliver
Copy link
Contributor

Sounds like a nice improvement to add

@caniszczyk
Copy link
Contributor

@toffaletti feel free to issue a pull request when you're ready

@toffaletti
Copy link
Contributor Author

Apologies, I was under the impression that mentioning the issue id in the commit message would turn this into a pull request.

@caniszczyk
Copy link
Contributor

This is fixed now in a3e552c

@adityapooniya
Copy link

Clearly Define the issue in RateTracker. Which type of parameters based on this RateTracker tracking the result... Then we have solve the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants