This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
StringDelimitedProcessor should handle multibyte characters properly #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static int DEFAULT_READ_COUNT = 64; | ||
| private final static int MAX_ALLOWABLE_BUFFER_SIZE = 500000; | ||
|
|
||
| private byte CR = 13; |
There was a problem hiding this comment.
i think both these should be static final
|
updated |
kevinoliver
added a commit
that referenced
this pull request
Mar 18, 2013
StringDelimitedProcessor should handle multibyte characters properly
|
Trying fda49a8 of master, my test app immediately fails with a constant stream of NumberFormatExceptions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our issue with messages containing multibyte UTF-8 characters. Related to issue #35