Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Add code coverage via coveralls.io #114

Merged
merged 1 commit into from
Jul 1, 2014
Merged

Add code coverage via coveralls.io #114

merged 1 commit into from
Jul 1, 2014

Conversation

caniszczyk
Copy link
Contributor

Code coverage is a good thing to show and results should show up at:
https://coveralls.io/r/twitter/hraven

Signed-off-by: Chris Aniszczyk zx@twitter.com

Signed-off-by: Chris Aniszczyk <zx@twitter.com>
@caniszczyk
Copy link
Contributor Author

Here's the typical output: https://coveralls.io/builds/922331

@vrushalic @jrottinghuis what do you folks think?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 620f15e on add-coveralls into * on master*.

@vrushalic
Copy link
Collaborator

Thanks Chris, this was something I had wanted to add for quite some time. Looks good to me.

Do you think we should mention the link (https://coveralls.io/r/twitter/hraven) somewhere like README or the description. I see it in that command in the README.md but I meant as a section that calls it out.

caniszczyk added a commit that referenced this pull request Jul 1, 2014
Add code coverage via coveralls.io
@caniszczyk caniszczyk merged commit a5f1cc3 into master Jul 1, 2014
@caniszczyk
Copy link
Contributor Author

I'll take that as a yes to merge :)

@vrushalic feel free to update the README if you wish, the more documentation the better. I only added the badge so you can see it next to the build results badge (generally that's where I look for these type of things, but that may just be me).

@caniszczyk caniszczyk deleted the add-coveralls branch July 1, 2014 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants