This repository has been archived by the owner on Jan 15, 2022. It is now read-only.
Merge master twitter only #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM based on the fact that the only change beyond the merge is to add the getJobDetails implementation for JobHistoryFileParserSpark. |
|
I'll look at this today. |
sjlee
pushed a commit
that referenced
this pull request
Jan 28, 2015
|
I merged it manually as the merge was non-trivial. @vrushalic, could you please look at the commit (8ad2e4e) to see if things are fine? Let's also check the travis CI. |
|
The build is green: https://travis-ci.org/twitter/hraven/builds/48691908 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is merging the changes that were on master branch onto the twitter_only branch (specifically the aggregation related enhancements made in #113 and merged onto master as part of a7dd908).
Almost all of it is old code except the following function getJobDetails in JobHistoryFileParserSpark. This function is being added now since the aggregation related pull request added this function to the JobHistoryFileParser interface.