Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parsing of old cstate names #229

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

brayniac
Copy link
Contributor

Problem

Older cstate names appended the microarchitecture abbreviation. For
example C1E-SKX for Intel Skylake's C1E state. Since the cstate
parsing logic assumed newer kernel versions which use a simpler
naming convention, it does not properly track time in each cstate
on older kernels.

Reported in #224

Solution

Improves the cstate parsing to split on '-' and take the first
token as the cstate name.

Result

As a result, the cstate sampling should work on older kernels.

Older cstate names appended the microarchitecture abbreviation. For
example C1E-SKX for Intel Skylake's C1E state. Since the cstate
parsing logic assumed newer kernel versions which use a simpler
naming convention, it does not properly track time in each cstate
on older kernels.

Improves the cstate parsing to split on '-' and take the first
token as the cstate name.

As a result, the cstate sampling should work on older kernels.
@brayniac brayniac merged commit 30827f5 into twitter:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant