Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitter and connections accepted/initiated counters to TCP sampler #247

Merged

Conversation

WUMUXIAN
Copy link
Contributor

@WUMUXIAN WUMUXIAN commented Oct 19, 2021

Problem
Via BPF, add jitter (median deviation of srtt) and two counters for the TCP sampler

  • connection accepted
  • connection initiated

Solution
Added the above mentioned metrics by introducing new kernel probes in BPF.

Result
Three new metrics introduced to the TCP sampler.

  • tcp/jitter - histogram
  • tcp/connection/accepted - counter
  • tcp/connection/initiated - counter

src/samplers/tcp/stat.rs Outdated Show resolved Hide resolved
@brayniac
Copy link
Contributor

Overall, this looks good. I'd like to see updates to the metrics documentation docs/METRICS.md to go with the new metric. Also see the comment about the name of the new enum variant.

We can ignore the failing 'audit' check, I will address separately as it's unrelated to this PR - also unrelated is that the runs on 'ubuntu xenial' seem to be stuck queued forever. I think it's safe to ignore both these CI issues.

Please address the docs and my comment on the enum variant and then I'll be happy to merge

@brayniac brayniac merged commit c882f32 into twitter:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants