Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLP and retransmit timeouts counters to TCP sampler #253

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Add TLP and retransmit timeouts counters to TCP sampler #253

merged 5 commits into from
Nov 16, 2021

Conversation

rittme
Copy link
Contributor

@rittme rittme commented Nov 10, 2021

Problem

Add two new TCP probes:

  • A probe to measure Tail Loss Probes (TLP) sent.
  • A probe to measure TCP Retransmit timeouts (RTO), reflecting how congested the network is.

Solution

Added two BPF kernel probes to count TLP and RTO events.

Result

Two new metrics introduced to TCP sampler:

  • tcp/ tlp
  • tcp/retransmit_timeout

WUMUXIAN
WUMUXIAN suggested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@WUMUXIAN WUMUXIAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tlp one looks correct, but I think the RTO one needs to change to another kernel probe.

src/samplers/tcp/mod.rs Outdated Show resolved Hide resolved
WUMUXIAN
WUMUXIAN approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@WUMUXIAN WUMUXIAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now.

brayniac
brayniac reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@brayniac brayniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the metric name, this looks good. I think it might be better overall to keep grouping metrics that are on the TX path together.

docs/METRICS.md Outdated Show resolved Hide resolved
@rittme rittme requested a review from brayniac November 11, 2021 03:55
@brayniac brayniac merged commit 9bdf951 into twitter:master Nov 16, 2021
WUMUXIAN pushed a commit to WUMUXIAN/rezolus that referenced this pull request Nov 17, 2021
@rittme @WUMUXIAN
Add TLP and retransmit timeouts counters to TCP sampler (twitter#253)
1c9dcf4 
* Add TCP Tail Loss Recovery Probes sampler via BPF
* Add TCP Retransmit timeout sampler via BPF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WUMUXIAN WUMUXIAN WUMUXIAN approved these changes

@brayniac brayniac brayniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rittme @WUMUXIAN @brayniac