Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkmjar is broken #192

Closed
xeno-by opened this issue Aug 12, 2018 · 1 comment
Closed

Checkmjar is broken #192

xeno-by opened this issue Aug 12, 2018 · 1 comment
Labels
Check

Comments

@xeno-by
Copy link
Contributor

xeno-by commented Aug 12, 2018 •
edited
Loading 

--- current implementation
+++ correct implementation
diff --git a/check/src/main/scala/rsc/checkmjar/Checker.scala b/check/src/main/scala/rsc/checkmjar/Checker.scala
index fd8a495eb0..b4d8a855c4 100644
--- a/check/src/main/scala/rsc/checkmjar/Checker.scala
+++ b/check/src/main/scala/rsc/checkmjar/Checker.scala
@@ -259,7 +259,7 @@ class Checker(nscResult: Path, rscResult: Path) extends CheckerBase {
       }
       if (isOwnerVisible) {
         if ((sym.flags & PRIVATE) != 0) sym.owner.isInstanceOf[ExternalSymbol]
-        else false
+        else true
       } else {
         false
       }
@xeno-by xeno-by added the Check label Aug 12, 2018
@xeno-by xeno-by added this to the M4 milestone Aug 12, 2018
@xeno-by xeno-by self-assigned this Aug 12, 2018
@xeno-by xeno-by removed this from the M4 milestone Sep 13, 2018
@xeno-by xeno-by removed their assignment Sep 13, 2018
@xeno-by xeno-by added this to the M4 milestone Sep 25, 2018
@xeno-by xeno-by assigned xeno-by and unassigned xeno-by Sep 25, 2018
@xeno-by xeno-by removed this from the M4 milestone Sep 26, 2018
@xeno-by xeno-by changed the title Checkmjar has wrong implementation of EmbeddedSymbol.isVisible Checkmjar is broken Oct 9, 2018
This was referenced Oct 9, 2018
Closed
Open
@xeno-by
Copy link
Contributor Author

xeno-by commented Oct 10, 2018

Superseded by #243.

@xeno-by xeno-by closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Check
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xeno-by