Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Checkscalasig #243

Open
xeno-by opened this issue Oct 10, 2018 · 0 comments
Open

Rethink Checkscalasig #243

xeno-by opened this issue Oct 10, 2018 · 0 comments
Labels

Comments

@xeno-by
Copy link
Contributor

xeno-by commented Oct 10, 2018

Checkmjar (currently called "Checkscalasig") has really unlucky history.

One of the pull requests in August inadvertently broke Checkmjar in a really outrageous way: it started producing false negatives, ignoring tons of legitimate errors. By the time when I found that out (#192), fixing the brokenness was no longer easy - although the fix for Checkmjar was trivial, applying it broke MjarTests in a very non-obvious way.

Since I was preoccupied with something else at that point, I decided to push back fixing Checkmjar, and of course, more and more issues started creeping in: #211 and #228. The technical debt around Checkmjar was becoming more and more unsettling.

Surprisingly, despite that we were effectively lacking any systematic way to check mjars, that didn't stop us from making progress. It turned out that despite the tons of errors that Checkmjar used to show us, we only needed to fix a handful of issues to successfully compile a pretty big case study project. While this anecdote doesn't prove anything, it definitely gives some food for thought.

In #241, I decided to take a radical step forward. I announced Checkmjar bankruptcy and deleted Checkmjar and everything that relied on it (Diffmjar and MjarTests). Let's start from scratch and get it right this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant