Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain wontfix comments in Checkmjar #228

Closed
xeno-by opened this issue Sep 25, 2018 · 1 comment
Closed

Explain wontfix comments in Checkmjar #228

xeno-by opened this issue Sep 25, 2018 · 1 comment
Assignees
Labels

Comments

@xeno-by
Copy link
Contributor

xeno-by commented Sep 25, 2018

def loop(tpe: Type): Type = {
  tpe match {
    case NoType =>
      NoType
    case NoPrefix =>
      NoPrefix
    case ThisType(sym) =>
      // WONTFIX: https://github.com/twitter/rsc/issues/90
      val sym1 = NoSymbol
      ThisType(sym1)
    case SingleType(pre: Type, sym: Symbol) =>
      // WONTFIX: https://github.com/twitter/rsc/issues/90
      val pre1 = loop(normalizePrefix(pre))
      val sym1 = sym
      SingleType(pre1, sym1)
    case ConstantType(lit) =>
      val lit1 = lit
      ConstantType(lit1)
    case TypeRef(pre, sym, targs) =>
      // WONTFIX: https://github.com/twitter/rsc/issues/90
      val pre1 = loop(normalizePrefix(pre))
      val sym1 = sym
      val targs1 = targs.map(loop)
      TypeRef(pre1, sym1, targs1)
    ...
  }
}
@xeno-by xeno-by added the Check label Sep 25, 2018
@xeno-by xeno-by added this to the M4 milestone Sep 25, 2018
@xeno-by xeno-by assigned xeno-by and unassigned xeno-by Sep 25, 2018
@xeno-by xeno-by removed this from the M4 milestone Sep 26, 2018
@xeno-by
Copy link
Contributor Author

xeno-by commented Oct 10, 2018

Superseded by #243.

@xeno-by xeno-by closed this as completed Oct 10, 2018
@xeno-by xeno-by self-assigned this Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant