Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scalameta tests for 2.12.8 #429

Closed
wiwa opened this issue Jun 4, 2019 · 2 comments
Closed

Fix Scalameta tests for 2.12.8 #429

wiwa opened this issue Jun 4, 2019 · 2 comments
Labels
Milestone

Comments

@wiwa
Copy link
Contributor

wiwa commented Jun 4, 2019

No description provided.

@wiwa wiwa added the Scalasig label Jun 4, 2019
@wiwa wiwa added this to the M7 milestone Jul 4, 2019
@wiwa
Copy link
Contributor Author

wiwa commented Jul 17, 2019

It's worth noting that MyersDiff is essentially O(N^2) (at least?) where N ~ 17000 for 2.12 predef... (this is where it "hangs").

It also would run very slowly for 2.11 predef, but we skip it since the scalasigs are equal. Need to investigate if the slowdown is okay. And should probably print to console that diffing takes a while. Of course, the best case is that we can just make the scalasigs equal.

@wiwa
Copy link
Contributor Author

wiwa commented Jul 17, 2019

Diffing algo uses random lookups: use arraylist rather than a List. Also, use jgit diff algo instead of myers (this alone is like 20x faster...).

@wiwa wiwa closed this as completed in a6bc0ea Aug 24, 2019
wiwa added a commit that referenced this issue Aug 24, 2019
Fix ScalametaTests; the previous expect texts were incorrect (fix #429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant