Remove FlowState and use a proxy pattern for that state #1001
This is a pretty big change as it causes all read taps to be wrapped by a proxy, but it does remove a big wart: the global static FlowState map.
Thoughts on this one?
@cwensel Note the ProxyTap here. I had to resort to reflection to make this work due to the .id in Taps being private. It would be nice to have this ProxyTap idea supporting in cascading so that we can attach extra information to Taps we get at runtime.
re Tap.id being private, you might find this useful
its to prevent confusion with the instance level getIdentifier etc, and its really not a user level value (unless you really want a guid on the Tap instance).
re ProxyTap, not sure how to surface that into java without a new dependency (or a bunch of code). we use javassist currently for such things (Lingual uses it for something similar I think, another reason to factor stuff out of that project)
On Aug 5, 2014, at 4:47 PM, P. Oscar Boykin firstname.lastname@example.org wrote: