Change toIteratorExecution to toIterableExecution #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egonina look at this one too, please? |
|
Note, the Execution Monad is new in 0.12, which the final has not been released. This is good to do before we release 0.12 final and have an API that people may have coded to. |
egonina
added a commit
that referenced
this pull request
Sep 19, 2014
Change toIteratorExecution to toIterableExecution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to #1055 we should be caching execution results. This means, all the results must be immutable, and Iterators are not. It is really not hard at all to only have the API put immutable values in the Executions, so here we just change from Iterator to Iterable.