Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer join handles case when both are empty #1065

Merged
merged 1 commit into from
Sep 24, 2014

Conversation

aposwolsky
Copy link
Contributor

  • If we are doing an outer join (K, A) x (K, B) by itself then it makes sense to assume that either A or B must exist for every key, but when composed with subsequent joins it is possible to get a key for which both A and B would be empty and the correct interpretation is to return an empty iterator (previously would do (None, None))

- If we are doing an outer join (K, A) x (K, B) by itself then it makes sense to assume that either A or B must exist for every key, but when composed with subsequent joins it is possible to get a key for which both A and B would be empty and the correct interpretation is to return an empty iterator (previously would do (None, None))
@johnynek
Copy link
Collaborator

Thanks a ton! I had to restart the build, but it looks like travis issues.

I'll make a new version today (0.12rc4) and if that looks good when we use it at Twitter, we'll publish 0.12 final.

@aposwolsky
Copy link
Contributor Author

great! thanks..

On Wed, Sep 24, 2014 at 2:46 PM, P. Oscar Boykin notifications@github.com
wrote:

Thanks a ton! I had to restart the build, but it looks like travis issues.

I'll make a new version today (0.12rc4) and if that looks good when we use
it at Twitter, we'll publish 0.12 final.

Reply to this email directly or view it on GitHub
#1065 (comment).

johnynek added a commit that referenced this pull request Sep 24, 2014
Outer join handles case when both are empty
@johnynek johnynek merged commit c175580 into twitter:develop Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants