Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long compile time for MultiJoin helpers #1109

Merged
merged 2 commits into from
Dec 2, 2014
Merged

Fix long compile time for MultiJoin helpers #1109

merged 2 commits into from
Dec 2, 2014

Conversation

isnotinvain
Copy link
Contributor

  1. Moved all the generated flatten* methods to an object as plain methods (instead of inside implicit classes) that operate on tuples (not KeyedListLikes) (renamed to flattenNestedTuple and flattenNestedOptionTuple to avoid collision with each other due to erasure)
  2. Generated only implicit flattenValueTuple methods for KeyedListLikes for arity 1-6

@ianoc
Copy link
Collaborator

ianoc commented Dec 2, 2014

LGTM, @johnynek thoughts?

@isnotinvain
Copy link
Contributor Author

quick style fix coming shortly

@isnotinvain
Copy link
Contributor Author

OK this is ready to go assuming @ianoc and @johnynek are happy with it

ianoc added a commit that referenced this pull request Dec 2, 2014
@ianoc
Merge pull request #1109 from twitter/alexlevenson/flatten-compile-ti…
6574132 
…me-fix

Fix long compile time for MultiJoin helpers
@ianoc ianoc merged commit 6574132 into develop Dec 2, 2014
@ianoc ianoc deleted the alexlevenson/flatten-compile-time-fix branch December 2, 2014 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isnotinvain @ianoc