Implicit execution context / easier switching between modes #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a reasonable incremental improvement. LGTM. Any thoughts @johnynek ? |
| * If the repl is started in Hdfs mode, this field is used to preserve the settings | ||
| * when switching Modes. | ||
| */ | ||
| var storedHdfsMode: Option[Mode] = None |
There was a problem hiding this comment.
can this be private[scalding]? Any reason to not make it?
|
Great idea. Love to ship it in 0.12.1. |
|
merge when green |
johnynek
added a commit
that referenced
this pull request
Dec 4, 2014
Implicit execution context / easier switching between modes
|
Do we have a develop-0.12 branch for this to merge to/did we do it? |
|
This just went into develop, which is still 0.12 compatible, I think. On Thu, Dec 4, 2014 at 2:48 PM, ianoc notifications@github.com wrote:
Oscar Boykin :: @posco :: http://twitter.com/posco |
|
This is great. Thanks so much for adding this nice feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would something like this makes sense? Is there a way to recover the hadoop config after parsing the args/mode, or would we need to preserve it at startup (like in this pr)?
Sriram pointed me to #989 which is related but more general (and more effort).