Fix some typos in TypedPipe docs, expand flatMap docs #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -265,11 +273,11 @@ trait TypedPipe[+T] extends Serializable { | |||
| def fork: TypedPipe[T] = onRawSingle(identity) | |||
|
|
|||
| /** | |||
| * WARNING This is dangerous, and maybe not what you think. | |||
| * WARNING This is dangerous, and maybe not be what you think. | |||
There was a problem hiding this comment.
maybe not be? or may not be?
There was a problem hiding this comment.
oh.. "maybe not what you think" makes sense to me now.
ok how about "and may not be what you think"?
|
when this looks good run: ./sbt unidoc to update the scaladoc (but it caches so you might need incognito or something to verify the upload, I couldn't do it with a force reload maybe due to the frames). |
|
OK, should we merge and then update the scaladoc? |
johnynek
added a commit
that referenced
this pull request
Dec 5, 2014
Fix some typos in TypedPipe docs, expand flatMap docs
|
push to gh-pages to see the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.