Adds a typedjson source

[ianoc]

So this involved adding json4s and elephantbird into the json package. Not sure if we mind that?

[isnotinvain]

It's not a showstopper, can't see how it would cause trouble, just wondering why we need two json libraries.

[ianoc]

Well json4s is just nicer for scala, and we've tested that it works well internally.

[johnynek]

can this be private?

[johnynek]

I guess to use this with the Fields API you'd need it. Nevermind.

[johnynek]

merge when green.

[isnotinvain]

I took a stab at using jackson last night just to see what's involved. Switching to the jackson API was easy, but I got hung up on adding a JobTest that exercises the source -- if transformInTest is false, then the source does no work, so there's nothing to test. If transformInTest is true, then it gets confused and tries to treat a TypedPipe[MyCaseClass] as a TypedPipe[String] and then says this is invalid json.

Anyway, probably not a huge deal, if we get classpath issues later we can revisit (json4s can apparently be backed by jackson, not sure how that's registered of if having out of sync json4s / jackson on the classpath is an issue)

[johnynek]

Just trying at the REPL is fine. You should be able to write, close the
repl, then open and read.

On Wed, Dec 10, 2014 at 9:59 AM, Alex Levenson notifications@github.com
wrote:

I took a stab at using jackson last night just to see what's involved.
Switching to the jackson API was easy, but I got hung up on adding a
JobTest that exercises the source -- if transformInTest is false, then
the source does no work, so there's nothing to test. If transformInTest
is true, then it gets confused and tries to treat a TypedPipe[MyCaseClass]
as a TypedPipe[String] and then says this is invalid json.

Anyway, probably not a huge deal, if we get classpath issues later we can
revisit (json4s can apparently be backed by jackson, not sure how that's
registered of if having out of sync json4s / jackson on the classpath is an
issue)

—
Reply to this email directly or view it on GitHub
#1129 (comment).

Oscar Boykin :: @posco :: http://twitter.com/posco